Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): migrate spinner to typescript #22080

Merged
merged 2 commits into from
Mar 9, 2020
Merged

chore(cli): migrate spinner to typescript #22080

merged 2 commits into from
Mar 9, 2020

Conversation

Naturalclar
Copy link
Contributor

Description

Migrate Spinner component in gatsby-cli to typescript.

Related Issues

#21995

@Naturalclar Naturalclar requested a review from a team as a code owner March 9, 2020 02:26
@Naturalclar Naturalclar changed the title chore: migrate spinner to typescript chore(cli): migrate spinner to typescript Mar 9, 2020
@blainekasten blainekasten mentioned this pull request Mar 9, 2020
Closed
blainekasten
blainekasten previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 9, 2020
@blainekasten
Copy link
Contributor

Looks like a conflict from previous merge. Mind fixing quick?

@Naturalclar
Copy link
Contributor Author

@blainekasten Resolved the conflict 👍

@blainekasten blainekasten merged commit 33de224 into master Mar 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/spinner branch March 9, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Naturalclar @blainekasten @MichaelDeBoey @wardpeet